D17325: Fix leak in kemoticons
Anthony Fieroni
noreply at phabricator.kde.org
Mon Dec 3 15:15:30 GMT 2018
anthonyfieroni added inline comments.
INLINE COMMENTS
> kemoticonstheme.cpp:57
> d = new KEmoticonsThemeData;
> - d->provider = p;
> + d->provider.reset(p);
> }
I've rethink it, this line can be a problem if pointer is not owned by us. Did you know consumer of the KEmoticonsTheme?
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D17325
To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181203/fbbe7d40/attachment.html>
More information about the Kde-frameworks-devel
mailing list