D17317: match and tc setting

[Jan Grulich]

jgrulich added a comment.


  And you submitted only changes on top of your changes.

INLINE COMMENTS

> tcsettingtest.cpp:92
> +                    // Here the maps should have same keys so compare QVariantMaps as we do now
> +                    QCOMPARE(listMap, listMap1);
> +                    ++comparedMaps;

I liked your original solution better, I mean the way you compared if you are going to compare correct maps. Anyway, this still doesn't compare the maps properly, you have to go value by value.

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181203/cacec721/attachment-0001.html>