D17331: Extend PositionCodec unit tests, better code coverage
Stefan Brüns
noreply at phabricator.kde.org
Mon Dec 3 14:54:18 GMT 2018
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
The test never tested position increments larger than 1, as the positions
where divided by the docId. Multibyte (i.e. value >= 128) position
steps where completely omitted.
Use identical datasets in the functional tests and in the benchmarks.
TEST PLAN
ctest
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D17331
AFFECTED FILES
autotests/benchmarks/positioncodecbenchmark.cpp
autotests/unit/codecs/positioncodectest.cpp
To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181203/606c3ce4/attachment.html>
More information about the Kde-frameworks-devel
mailing list