D17315: Avoid potential nullptr access for Document use reference instead
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Dec 2 16:03:08 GMT 2018
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Using a TermGenerator without backing document is pointless and can
even crash when the document has been initialized with a nullptr.
TEST PLAN
ctest
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D17315
AFFECTED FILES
autotests/integration/querytest.cpp
autotests/unit/engine/termgeneratortest.cpp
src/engine/termgenerator.cpp
src/engine/termgenerator.h
src/file/basicindexingjob.cpp
src/file/extractor/result.cpp
To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/e5583791/attachment.html>
More information about the Kde-frameworks-devel
mailing list