D17252: ovs-patch and ovs-port setting

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ovspatchsettingtest.cpp:30
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PATCH_SETTING_NAME   "ovs-patch"
> +#define NM_SETTING_OVS_PATCH_PEER           "peer"

This define is not necessary.

> ovsportsettingtest.cpp:30
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PORT_SETTING_NAME        "ovs-port"
> +

This define is not necessary.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17252

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/81293cf8/attachment.html>