D17302: add simple test for string merging
Alexander Stippich
noreply at phabricator.kde.org
Sun Dec 2 14:49:04 GMT 2018
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in resulttest.cpp:40
> No need to reset the default constructed `Baloo::Document` with a default constructed one.
Actually it is. The TermGenerators are otherwise only initialized with nullptr, and consequently will crash. That is something that should be fixed (separately).
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D17302
To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/752cd3fe/attachment.html>
More information about the Kde-frameworks-devel
mailing list