D17281: Add icon to KBuildSycocaProgressDialog cancel button

Elvis Angelaccio noreply at phabricator.kde.org
Sun Dec 2 09:48:18 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> kbuildsycocaprogressdialog.cpp:71
>      setAutoClose(false);
> +    QDialogButtonBox* dialogButtonBox = new QDialogButtonBox(QDialogButtonBox::Cancel);
> +    setCancelButton(dialogButtonBox->button(QDialogButtonBox::Cancel));

Please also pass `this` as parent, otherwise the button box will leak.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/41612c77/attachment.html>


More information about the Kde-frameworks-devel mailing list