Increasing KF5 cmake requirement to 3.5?

[Albert Astals Cid]

El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid va escriure:
> El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va escriure:
> > > -----Original Message-----
> > > I'm going to suggest it to increase it to 3.6, it would still most
> > probably be a lie
> > > since i don't think any of use uses such an old (2 years version) either
> > 
> > We currently do still build the latest KDE Frameworks, Plasma, and
> > Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2.
> 
> Ok, good, then maybe actually increase it to 3.5 only and it won't be a lie because the openSUSE people are using it :)

Since noone complained I increased the required cmake version to 3.5 to all modules except e-c-m because it already had a different required version than the others so it seems a bit special in that regard?

@dfaure I pushed a new script to the release-tools repo that does the replacement.

Cheers,
  Albert

> 
> Cheers,
>   albert
> 
> >  
> > Only problem so far: discover started to use a new feature of cmake 3.6 in
> > the latest (bugfix) version, namely the IMPORTED_TARGET option to
> > pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore
> > with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found")
> > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14&id=d9ccf1d41fc3265ae
> > e9e01eebbc090b163fefe07
> > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14&id=2fe3d58fc652fc995
> > 7f063cbbd0722dc1cf45730
> > (we couldn't build the fwupd backend anyway though because fwupd is too old)
> > 
> > Kind Regards,
> > Wolfgang
> > 
> > 
> > 
> 
> 
> 
> 
>