D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kbuildsycocaprogressdialog.cpp:71-73
> +    QDialogButtonBox dialogButtonBox;
> +    dialogButtonBox.setStandardButtons(QDialogButtonBox::Cancel);
> +    setCancelButton(dialogButtonBox.button(QDialogButtonBox::Cancel));

I'm surprised this works. `setCancelButton()` take ownership of the button, but the button's parent is created on the stack.

I'd just create it on the heap to be sure. Better safe then sorry.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181201/b010db35/attachment.html>