D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  In D15999#369135 <https://phabricator.kde.org/D15999#369135>, @ndavis wrote:
  
  > In D15999#369134 <https://phabricator.kde.org/D15999#369134>, @pstefan wrote:
  >
  > > In D15999#369132 <https://phabricator.kde.org/D15999#369132>, @ndavis wrote:
  > >
  > > > In D15999#369131 <https://phabricator.kde.org/D15999#369131>, @pstefan wrote:
  > > >
  > > > > In D15999#369066 <https://phabricator.kde.org/D15999#369066>, @ndavis wrote:
  > > > >
  > > > > > With colorschemes applied, these will be your colors:
  > > > > >
  > > > > >               | Ring    | Background | Symbol  |
  > > > > >               | ------- | ---------- | ------- |
  > > > > >        Breeze | #fcfcfc | #eff0f1    | #232627 |
  > > > > >   Breeze Dark | #232629 | #31363b    | #eff0f1 |
  > > > > >
  > > > >
  > > > >
  > > > > Why would the ring and the background have different colors? They both have the same class attribute.
  > > >
  > > >
  > > > I must have had a slightly older version of the patch because I swear I saw the ring using `ViewBackground` and the background using `Background`. I downloaded the patch again and everything looks fine there. `go.svgz` still has `#31363b` and `#232629` as the default colors for the background and ring. Is this intentional?
  > >
  > >
  > > They do not have a default color for me.
  >
  >
  > Here's what I'm seeing: F6449126: Screenshot_20181201_013830.png <https://phabricator.kde.org/F6449126>
  
  
  Ahh, now I get what you mean. Yes that was intentional. But only insofar as to check if I had set the class attributes correctly. I will change it when I get home.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181201/9bdd2cc4/attachment-0001.html>