D15180: kioexecd: watch for creations or modifications of the temporary files

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> broulik wrote in kioexecd.cpp:58
> If you can be sure kioexec creates a folder per temp file (it might does), then this is probably fine.
> Also check kioexec what it does when the process closes, if it also recursively removes the temp dir

kioexec creates a folder per temp file.
kioexec doesn't remove recursively, therefore the temporary directory will not be deleted if the program creates backup files, like a.txt~

> broulik wrote in kioexecd.cpp:73
> I see. Previously it would just remove the watcher when the temp file is removed. Not sure how to fix it now, maybe we need an `unwatch` dbus call.
> Imho we shouldn't change the behavior here too much, ie. "randomly" watching the parent dir instead of the actual file passed in as argument but instead introduce a `watchDirectory` dbus call that exhibits the new behavior? Not sure.

The watch will be left as it was, introducing the create case and removing the deleted case.

I've implemented an unwatch dbus call.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180831/0ecadd80/attachment.html>