D15180: kioexecd: watch for creations or modifications of the temporary files
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Aug 31 09:39:16 BST 2018
broulik added inline comments.
INLINE COMMENTS
> kioexecd.cpp:58
> qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" << info.fileName();
> - QFile::remove(it.key());
> - QDir().rmdir(parentDir);
> + QDir(parentDir).removeRecursively();
> }
I'm not sure that's a good idea
> kioexecd.cpp:73
> + QDir qd(path);
> + m_watcher->addDir(qd.filePath(path), KDirWatch::WatchMode::WatchSubDirs);
> m_watched.insert(path, QUrl(destUrl));
You never unwatch the dir
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15180
To: jtamate, #frameworks, broulik, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180831/d0500975/attachment.html>
More information about the Kde-frameworks-devel
mailing list