D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero
Fabian Vogt
noreply at phabricator.kde.org
Fri Aug 31 09:29:09 BST 2018
fvogt added a comment.
With a few modification the patch is correct and necessary though.
statfs (not statvfs!) has in the documentation: `Fields that are undefined for a particular filesystem are set to 0.`. Currently KIO just returns garbage in that case.
The KMountPoint calls above are not necessary with statvfs/statfs and in the gvfs case even hurt.
That it works now due to KMountPoint changes is just a side effect and a workaround, not a proper fix.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15146
To: broulik, dfaure, ngraham, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180831/7bd749c4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list