D15141: [KSambaShareData] Accept spaces in ACL host name

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ksambasharetest.cpp:26
> +
> +#include <QtTest>
> +

This includes all of QtTest *and* all of QtCore. Please use <QTest> instead.

> ksambasharetest.h:21
> +
> +#ifndef KSAMBASAHRETEST_H
> +#define KSAMBASAHRETEST_H

typo: s/AH/HA/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15141

To: broulik, dfaure, fvogt
Cc: ngraham, bruns, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180830/b273627e/attachment.html>