D15098: make push/pop part of ConfigModule API

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> configmodule.cpp:170
>          d->_qmlObject->setSource(QUrl::fromLocalFile(package.filePath("mainscript")));
> -        d->_qmlObject->engine()->rootContext()->setContextProperty(QStringLiteral("kcm"), this);
> +        d->_qmlObject->rootContext()->setContextProperty(QStringLiteral("kcm"), this);
>          d->_qmlObject->completeInitialization();

good catch, could be the thing Kai was talking about the other day.
Should be a separate commit though

> configmodule.h:392
> +     * returns the width the kcm wants in column mode.
> +     * When a columnWidth is valid ( > 0 ) and less than the systemsettings' view width,
> +     * when there will be multiple pages pushed to the stack, more than one will be visible at once, and the first ones will be a sidebar to the last page pushed.

I don't understand this sentence. It contains two "when"s

> configmodule.h:454
> +    /**
> +     * pop the last page of the KCM hyerarchy
> +     * @since 5.50

hierarchy

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D15098

To: mart, #plasma
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180830/2bc4af9a/attachment.html>