D15141: [KSambaShareData] Accept spaces in ACL host name

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Aug 30 00:12:30 BST 2018


bruns added a comment.


  In D15141#317370 <https://phabricator.kde.org/D15141#317370>, @broulik wrote:
  
  > > Any chance you can create a unit test?
  >
  > Will try. Should it just check a couple of strings for validity? And also check that the ACL it read are valid since they must be as they came from `net usershare`?
  
  
  For the beginning, a couple of strings which previously failed, and some which are ok before and after, are a good start.
  
  Some input which should be rejected would cover the majority of this functions scope.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15141

To: broulik, dfaure, fvogt
Cc: ngraham, bruns, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180829/7b8137df/attachment.html>


More information about the Kde-frameworks-devel mailing list