D15071: Don't draw frames and shadows around images with transparency

[Nathaniel Graham]

ngraham added a comment.


  In D15071#315839 <https://phabricator.kde.org/D15071#315839>, @broulik wrote:
  
  > I'm a bit concerned that removing the frame most of the time blurs the lines between "previews of images" and "actual file icons", especially for the SVG case.
  
  
  Thing is, this is what users have been clamoring for, especially for SVG icons. In fact, the status quo even has logic to detect them and not draw frames for them. It just doesn't work very well.
  
  > Now they all look like proper file icons rather than previews of the file's contents. I can see that an EXE "thumbnail" is a proper file icon but in many other cases it's misleading.
  
  What's misleading exactly?
  
  > Why did the `ThumbCreator` frame flag get deprecated in the first place?
  
  No idea...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: markg, abetts, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180827/47d3d9e5/attachment.html>