D14236: Add some improvements to kate-syntax-highlighter for use in scripting

[Christoph Cullmann]

cullmann added a comment.


  I am not sure about the default argument for title, why not just have there QString() and in the code instead of isNull() an isEmpty => use file name fallback.
  The definitionForMimeType must perhaps use the priority, too, if there are duplicates, like the definitionForFileName function.
  Otherwise: Volker, what do you think?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14236

To: xciml, #framework_syntax_highlighting, vkrause
Cc: cullmann, pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180826/b30a3cdd/attachment-0001.html>