D15072: [server] Abort drag start on correct conditions and without posting error

Roman Gilg noreply at phabricator.kde.org
Sat Aug 25 11:54:08 BST 2018


romangg added a comment.


  I updated the autotest. Note that the old autotest was broken anyway because the wrong pointer button serial was used when the drag was started and by that aborted in SeatInterface. The new test fails on `testDragInternally` with:
  
    QFATAL : TestDataDevice::testDragInternally(grab and focus) ASSERT: "source" in file /home/roman/dev/kde/src/frameworks/kwayland/src/server/dataoffer_interface.cpp, line 153
    FAIL!  : TestDataDevice::testDragInternally(grab and focus) Received a fatal error.
  
  what is a different problem. A data offer should not be created when there is no data source. The old autotest did not capture this problem, since the drag was aborted on the SeatInterface.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15072

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180825/81a852e9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list