D15072: [server] Abort drag start on correct conditions and without posting error

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  A drag start request should be dismissed when the client does not have an
  implicit pointer grab or the currently focused pointer surface is not the
  origin. The conditions for that were wrong in the past.
  
  Also just ignore the request and not post directly an error, that potentially
  kills the client since by concurrency the client might have send a valid
  request, that got invalidated through grab or focus change at the same time
  on the server side.

TEST PLAN
  Manually.

REPOSITORY
  R127 KWayland

BRANCH
  startDragAbortFix

REVISION DETAIL
  https://phabricator.kde.org/D15072

AFFECTED FILES
  src/server/datadevice_interface.cpp

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180825/2b32931c/attachment.html>