D11529: Balooctl: Deindex unfound files with check command.

[James Smith]

smithjd added inline comments.

INLINE COMMENTS

> bruns wrote in indexcleaner.cpp:76
> Undesired detach

This example will also detach with or without a const intermediate.

> ...returning a copy from a method means that the copy is shared and has negative side-effects when used with range-based loops. - https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops

> bruns wrote in indexcleaner.cpp:82
> Undesired detach

Same as above.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh, broulik, bruns
Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/754f3c96/attachment-0001.html>