D15047: Export the StorageDevices object.
James Smith
noreply at phabricator.kde.org
Fri Aug 24 20:55:33 BST 2018
smithjd added a comment.
In D15047#314741 <https://phabricator.kde.org/D15047#314741>, @bruns wrote:
> In D15047#314485 <https://phabricator.kde.org/D15047#314485>, @smithjd wrote:
>
> > In D15047#314477 <https://phabricator.kde.org/D15047#314477>, @bruns wrote:
> >
> > > There is no need for this, just create a new StorageDevices where you need it.
> > > Creating a second StorageDevices instance in a process is quite cheap.
> >
> >
> > Creating a separate object cluttered the console with duplicated debug output and raised a threading error.
>
>
> Then your code is wrong anyway. This is lazy initialization, and if you can not not guarantee it is save to do so, don't do it.
Duplicated debug output is also undesireable...
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15047
To: smithjd, broulik
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/c6d5e058/attachment.html>
More information about the Kde-frameworks-devel
mailing list