D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Split this into independent changes.
  Add add comprehensive description to the summary - a bug reference is insufficient.

INLINE COMMENTS

> fileindexscheduler.cpp:98
> -        Q_EMIT stateChanged(m_indexerState);
> -        return;
>      }

You sneak in a unmentioned and significant change - you allow to run several indexer tasks to run in parallel!

> fileindexscheduler.cpp:117
>  
> -        m_threadPool.start(runnable);
> -        m_modifiedFiles.clear();
> -        m_indexerState = ModifiedFiles;
> -        Q_EMIT stateChanged(m_indexerState);
> -        return;
> +        m_threadPool.start(runnable, -(int)NewFiles);
> +        runnableStarted(NewFiles);

Whats that supposed to do (I have an idea, but thats ugly ...)

> fileindexscheduler.h:92
>  
> +    QList<Baloo::IndexerState> m_indexerStates;
> +

Make this a QFlags ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/69ad2ab3/attachment.html>