D15047: Export the StorageDevices object.

[Stefan Brüns]

bruns added a comment.


  There is no need for this, just create a new StorageDevices where you need it.
  Creating a second StorageDevices instance in a process is quite cheap.

INLINE COMMENTS

> fileindexerconfig.cpp:322
>      // been explicitly added in the include list
> -    const auto allMedia = m_devices->allMedia();
> -    for (const auto& device: allMedia) {
> +    for (const auto& device: storageDevices()->allMedia()) {
>          const QString mountPath = device.mountPath();

This is bad, you remove the const from the QList<>
Read up about Qt and detaching ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15047

To: smithjd, broulik
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/38b29354/attachment-0001.html>