D15013: balootctl: fix 396535

[James Ausmus]

jausmus added a comment.


  In D15013#313885 <https://phabricator.kde.org/D15013#313885>, @mgallien wrote:
  
  > In D15013#313880 <https://phabricator.kde.org/D15013#313880>, @jausmus wrote:
  >
  > > In D15013#313867 <https://phabricator.kde.org/D15013#313867>, @anthonyfieroni wrote:
  > >
  > > > Do not use QDir::separator
  > > >
  > > >   if (!folder.endsWith(QLatin1Char('/')) {
  > > >       folder += QLatin1Char('/');
  > > >   }
  > > >
  > >
  > >
  > > Does balooctl not need cross platform support?
  >
  >
  > I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/
  
  
  Got it - will update and resubmit. Thanks!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15013

To: jausmus, bruns
Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180823/eaf2d98b/attachment-0001.html>