D15013: balootctl: fix 396535

[Matthieu Gallien]

mgallien added a comment.


  In D15013#313880 <https://phabricator.kde.org/D15013#313880>, @jausmus wrote:
  
  > In D15013#313867 <https://phabricator.kde.org/D15013#313867>, @anthonyfieroni wrote:
  >
  > > Do not use QDir::separator
  > >
  > >   if (!folder.endsWith(QLatin1Char('/')) {
  > >       folder += QLatin1Char('/');
  > >   }
  > >
  >
  >
  > Does balooctl not need cross platform support?
  
  
  I believe this explains why QDirSeparator should not be used here: http://agateau.com/2015/qdir-separator-considered-harmful/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15013

To: jausmus
Cc: mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180823/43111e8b/attachment.html>