D14723: Add option to disable KWallet entirely in the new wallet dialog

Fabian Vogt noreply at phabricator.kde.org
Mon Aug 20 20:38:32 BST 2018


fvogt added inline comments.

INLINE COMMENTS

> aacid wrote in knewwalletdialog.h:67
> do we really need to rename this?

It's not just a rename - it's doing the opposite now as there are three instead of two actions.

If you follow which slot this ends up, it's responsible for switching between "Next" and "Finished" buttons in the step. Next is only shown if GPG is selected, so this makes IMO more sense.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180820/02a05a55/attachment.html>


More information about the Kde-frameworks-devel mailing list