D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

[Vlad Zagorodniy]

zzag created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  On Wayland, DialogShadows doesn't attach empty tiles for disabled
  borders. Yet, it sets offset of 1 for them. This results in visual
  artifacts like this
  
  F6206088: before.png <https://phabricator.kde.org/F6206088>
  
  //KWin thinks that there is 1px tall shadow in the bottom.//
  
  In general we don't need to pass empty shadow tiles for disabled
  borders. Thus, that's fine to set 0 offset for them.

TEST PLAN
  - Started kwin_wayland:
  
    dbus-launch kwin_wayland --windowed --xwayland
  
  - Launched latte-dock and kate:
  
    unset DISPLAY QT_QPA_PLATFORM=wayland latte-dock & QT_QPA_PLATFORM=wayland kate
  
  - Opened calendar popup:
  
  F6206090: after.png <https://phabricator.kde.org/F6206090>

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14946

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp

To: zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180820/c8446625/attachment-0001.html>