D11604: kdirlistertest doesn't fail at random

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks. Almost there :-)

INLINE COMMENTS

> kdirlistertest.cpp:658
> +    QTRY_COMPARE(dirLister2.spyStarted.count(), 1);
>      QCOMPARE(dirLister2.spyCompleted.count(), 1);
>      QCOMPARE(dirLister2.spyCompletedQUrl.count(), 1);

*That* one should probably be a QTRY_COMPARE, since dirLister2 will first emit started, and then completed later.

> kdirlistertest.cpp:1121
> +    QTRY_VERIFY(m_dirLister.isFinished());
> +    QTRY_VERIFY(m_items.isEmpty());
>  

No TRY_ here.

> kdirlistertest.cpp:1197
> +    QTRY_VERIFY(m_dirLister.isFinished());
> +    QTRY_COMPARE(m_items.count(), 0);
> +    QTRY_COMPARE(m_dirLister.spyItemsDeleted.count(), 1);

No TRY_ here

> kdirlistertest.cpp:1292
> +    QTRY_COMPARE(m_dirLister.spyClear.count(), 1);
> +    QTRY_COMPARE(m_dirLister.spyClearQUrl.count(), 0);
>      QList<QUrl> deletedUrls;

No TRY_ here, we can't "wait for nothing to happen" ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11604

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180819/ebe5a250/attachment-0001.html>