D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> icoutils_common.cpp:99
> +        // QtIcoHandler converts all images to 32-bit depth
> +        // but they store the actual depth of the icon extracted in custom text:
> +        // qtbase/src/plugins/imageformats/ico/qicohandler.cpp:455

grammatical nitpick:

> // QtIcoHandler converts all images to 32 bit depth**,**
>  // but **it stores** the actual depth of the icon extracted in custom text:

i.e. missing `,` in the first line,  and third person

otherwise it's good to go

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180818/4c9cee72/attachment.html>