D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

David Faure noreply at phabricator.kde.org
Sat Aug 18 00:06:35 BST 2018


dfaure created this revision.
dfaure added a reviewer: cullmann.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  QFile::close() doesn't return a value, but sets an error string instead,
  we need to check for that and set it in KCompressionDevice so apps can check for that in turn.

TEST PLAN
  Saving into /tmp/mnt/test.gz with kate, with the setup described in
  https://phabricator.kde.org/D14890

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14913

AFFECTED FILES
  src/kcompressiondevice.cpp

To: dfaure, cullmann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180817/9ea09b45/attachment.html>


More information about the Kde-frameworks-devel mailing list