D14897: InlineNote: Pimpl inline note data without allocs
Sven Brauch
noreply at phabricator.kde.org
Fri Aug 17 12:07:54 BST 2018
brauch added a comment.
Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14897
To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180817/0e77ff2d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list