D14274: Modelines: add byte-order-mark & small fixes

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Git commit e1c3d16a35ddae90de6e457a31f54d899abb84c8 by Christoph Cullmann, on behalf of Nibaldo González.
  Committed on 15/08/2018 at 18:22.
  Pushed by cullmann into branch 'master'.
  
  Modelines: add byte-order-mark & small fixes
  
  Summary:
  Changes:
  
  - Add missing keyword: `byte-order-mark` (there is only "byte-order-marker" and "bom"). Obtained from: https://docs.kde.org/stable5/en/applications/katepart/config-variables.html
  - Remove keywords delimiters "*" and "+", because in the "RemoveSpacesOptions" list, the keywords "*" and "+" are not highlighted.
  - Fix ";" in the "RemoveSpaces" context ("remove-trailing-spaces" variable). The character ";" it is not highlighted as in the rest of the variables, since when writing a value, the context ends.
  
  F6128802: modelines-spaces.png <https://phabricator.kde.org/F6128802>
  
  - For a strange reason, the use of `<IncludeRules context="##Modelines"/>`, in others files, causes the line continuation character ("\") to be highlighted as `dsNormal`. This is solved by removing the LineContinue rule in the "Normal" context in Modelines. I consider the LineContinue & DetectSpaces rules to be unnecessary in the "Normal" context, so I've eliminated them.
  
  F6128805: modelines-linecont.png <https://phabricator.kde.org/F6128805>
  
  I was going to add a test file, but there are errors when generating the html and ref files, even with the unmodified modelines.xml file :S
  
  Reviewers: turbov, dhaumann, cullmann, vkrause, #kate <https://phabricator.kde.org/tag/kate/>
  
  Reviewed By: cullmann, #kate <https://phabricator.kde.org/tag/kate/>
  
  Subscribers: kwrite-devel, kde-frameworks-devel
  
  Tags: #kate <https://phabricator.kde.org/tag/kate/>, #frameworks <https://phabricator.kde.org/tag/frameworks/>
  
  Differential Revision: https://phabricator.kde.org/D14274
  
  A  +10   -0    autotests/folding/modelines.py.fold
  A  +17   -0    autotests/html/modelines.py.html
  A  +10   -0    autotests/input/modelines.py
  A  +10   -0    autotests/reference/modelines.py.ref
  M  +7    -4    data/syntax/modelines.xml
  
  https://commits.kde.org/syntax-highlighting/e1c3d16a35ddae90de6e457a31f54d899abb84c8

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14274

To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180815/abb00631/attachment-0001.html>