D14856: Search: Add workaround for missing icons in Gnome icon-theme

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:1332
> +        // Gnome does not seem to have all icons we want, so we use fall-back icons for those that are missing.
> +        QIcon mutateIcon = QIcon::fromTheme(QStringLiteral("games-config-options"), QIcon::fromTheme(QStringLiteral("preferences-system")));
> +        QIcon matchCaseIcon = QIcon::fromTheme(QStringLiteral("format-text-superscript"), QIcon::fromTheme(QStringLiteral("format-text-bold")));

Doesn't this evaluate the fallback always, even if not needed?
IIRC QIcon::fromTheme is not really lightweight ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180815/2765c257/attachment.html>