D14859: Don't try to call transaction documentUrl with a 0 id

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:140
>              fid = Baloo::devIdAndInodeToId(devId, inode);
> -            url = QFile::decodeName(tr.documentUrl(fid));
> +            if (fid) {
> +                url = QFile::decodeName(tr.documentUrl(fid));

maybe `fid > 0` for clarity

> main.cpp:143
> +            } else {
> +                stream << i18n("No index information for") << url << endl;
> +                continue;

string puzzle, please use placeholders for i18n()

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14859

To: jtamate, #frameworks, pino
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180815/912cd6b7/attachment.html>