D14828: remove highlighting download dialog

Christoph Cullmann noreply at phabricator.kde.org
Tue Aug 14 13:30:30 BST 2018


cullmann created this revision.
cullmann added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  rational:
  
  1. there is one frameworks release per month that already provides a stream of hl updates
  2. often new highlightings anyways need a new frameworks version
  3. one can easily update only a part of the files which leads to broken other highlighting that include parts of them
  4. the updates might easily break the non-downloadable indenters
  
  GUI: highlighting download dialog removed

TEST PLAN
  make
  make test

REPOSITORY
  R39 KTextEditor

BRANCH
  no-hl-download (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14828

AFFECTED FILES
  src/dialogs/filetypeconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodeconfigpage.h

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180814/f2cb2fb2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list