D14779: Fix 'kformattest fails with installed kcoreaddons language package'

Albert Astals Cid noreply at phabricator.kde.org
Tue Aug 14 12:37:04 BST 2018


aacid added a comment.


  Personally i would include (and use) a fake translation as part of the tests and then it would just evaluate to the actual result, i.e.
  
    QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour(s)"));
  
  would end up being
  
    QCOMPARE(format.formatSpelloutDuration(3610000), QStringLiteral("1 hour"));
  
  because we're using the "fake" translation.
  
  But i understand that is much more work and this makes the test pass already, so if noone disagrees i think this is good enough :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks, cfeck
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180814/34635a5e/attachment.html>


More information about the Kde-frameworks-devel mailing list