D14308: [Exe Thumbnailer] Improve icon selection algorithm

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Aug 13 20:02:44 BST 2018


bruns added a comment.


  Should be "Prefer higher BPP" (bits per pixel), DPI is dots per inch, i.e. spatial resolution.

INLINE COMMENTS

> icoutils_common.cpp:100
> +        // but they store the actual depth of the icon extracted in custom text:
> +        // qtbase/src/plugins/imageformats/ico/qiconhandler.cpp:455
> +        int depth = icon.text(QStringLiteral("_q_icoOrigDepth")).toInt();

qico_handler.cpp (no "n")

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr
Cc: anthonyfieroni, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180813/15c5951e/attachment.html>


More information about the Kde-frameworks-devel mailing list