D14800: kioslave/Mac : proxy the bundle-exec and make an agent
René J.V. Bertin
noreply at phabricator.kde.org
Mon Aug 13 17:46:35 BST 2018
rjvbb created this revision.
rjvbb added a project: Frameworks.
rjvbb requested review of this revision.
REVISION SUMMARY
(I thought I had committed this already...)
On Mac, kioslave must be built as an app bundle to prevent keyboard input issues (for instance during the authentication step with kio-gdrive) but it must also be found in the expected location and, ideally, not put up a menu bar nor appear in the app switcher.
This patch achieves all that:
- installs a wrapper script that proxies the kioslave app bundle-exec
- adds the CoreFoundation magic code that instructs the application to behave as an agent.
TEST PLAN
Works as intended with all kioslaves I tested.
Alternatively one could use a Mac-specific hard-codec path to launch the bundle-exec instead of installing the wrapper script. That would require patching klauncher - and I don't know if this the only place where kioslave is started.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14800
AFFECTED FILES
src/kioslave/CMakeLists.txt
src/kioslave/kioslave.cpp
src/kioslave/kioslave_wrapper.in
To: rjvbb
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180813/c9e6a619/attachment.html>
More information about the Kde-frameworks-devel
mailing list