D14757: Warn user before copy operation if available space is not enough

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> CMakeLists.txt:153
>   KF5::DBusAddons            # KDEInitInterface
> + KF5::WidgetsAddons
>  )

Please remove

> copyjob.cpp:49
>  
> +#include <kmessagebox.h>
> +

Please remove

> copyjob.cpp:892
> +            SimpleJobPrivate *sjp;
> +            int msgRes;
> +            msgRes = sjp->requestMessageBox(JobUiDelegateExtension::WarningYesNo,

join with next line, this isn't 1980-style C code ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180813/7016a22b/attachment.html>