D13880: [KMoreTools] Reduce menu hierarchy

Nicolas Fella noreply at phabricator.kde.org
Mon Aug 13 12:04:40 BST 2018


nicolasfella added a comment.


  In D13880#307597 <https://phabricator.kde.org/D13880#307597>, @dhaumann wrote:
  
  > What is the current state of this?
  >  The new private functions should move to the pimpl class behind the d-pointer.
  >
  > In general: Looking at the public classes, /all/ the private functions should have been hidden behind the pimpl class...
  
  
  We agreed on how we want to structure the menu, but I haven't had time to implement it. IMHO it is out of scope for this patch, though. I think this patch is still an improvement for cases where aforementioned redesign won't be used and worth merging (after I address your comment)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180813/fc0b3889/attachment.html>


More information about the Kde-frameworks-devel mailing list