D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

David Faure noreply at phabricator.kde.org
Sun Aug 12 10:45:53 BST 2018


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:80
> +                    COMMAND ${CMAKE_COMMAND} -E
> +                        copy ${CMAKE_BINARY_DIR}/bin/libcorebindingsplugin.so ${CMAKE_BINARY_DIR}/bin/org/kde/plasma/core/libcorebindingsplugin.so)
> +add_custom_command(TARGET copy POST_BUILD

The filename won't work on Windows. Here's more portable syntax:

  add_custom_command(TARGET copy POST_BUILD
                      COMMAND ${CMAKE_COMMAND} -E
                      copy $<TARGET_FILE:corebindingsplugin> ${CMAKE_BINARY_DIR}/bin/org/kde/plasma/core/)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14743

To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180812/f9939084/attachment.html>


More information about the Kde-frameworks-devel mailing list