D14733: [KFormat] Add human readble list displaying function

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kformattest.cpp:396
> +
> +    QStringList testDate;
> +    QCOMPARE(format.formatList(testDate), QStringLiteral(""));

Why test**Date**?

> kformat.h:287
>       *
> -     * e.g. given formatDuration(60000), returns "1.0 minutes"
> +     * e.g. given formatDecimalDuration(60000), returns "1.0 minutes"
>       *

No unrelated changes, please.

> kformatprivate.cpp:477
>  
> -    // Handle correctly problematic case #1 (look at KFormatTest::prettyFormatDuration())
> +    // Handle correctly problematic case #1 (look at KFormatTest::formatSpelloutDuration())
>      if (seconds == 60) {

No unrelated changes, please.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180810/4019c125/attachment-0001.html>