D14730: Sort returned formats in Definition::formats() by id

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Sorting the formats() by id results in the same order as the
  itemDatas are defined in the xml file. This is required for
  several reasons:
  
  - KTextEditor currently uses the first format if no format was explicitly specified (which typically is "Normal Text")
  - Fonts & Colors will list the itemDatas in correct order
  - Printing the syntax guide is sorted correctly as well

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sort-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14730

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180810/5c805a6a/attachment.html>