D13782: Ignore NTFS hidden flag for root volume

Wolfgang Bauer noreply at phabricator.kde.org
Thu Aug 9 09:27:21 BST 2018


wbauer added inline comments.

INLINE COMMENTS

> file_unix.cpp:567
> +                    if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN) {
> +                        const QString fullFilePath = QDir::cleanPath(QDir().absoluteFilePath(filename));
> +                        auto mountPoint = KMountPoint::currentMountPoints().findByPath(fullFilePath);

This still doesn't handle symlinks.
E.g. if you create a symlink to the NTFS partition's mount point/root dir on your desktop, it will still be hidden.

As mentioned, `const QString fullFilePath = QDir(filename).canonicalPath();` instead should fix that (and still handle `.` and `..`).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13782

To: broulik, dfaure, yurikoles, bruns
Cc: ngraham, oysteins, wbauer, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180809/76965212/attachment.html>


More information about the Kde-frameworks-devel mailing list