D14161: [KStyle] Use dialog-question for question icon

[Nathaniel Graham]

ngraham added a comment.


  In D14161#294031 <https://phabricator.kde.org/D14161#294031>, @rkflx wrote:
  
  > Thanks for noticing, LGTM and restores the proper icon indeed.
  >
  > > This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 <https://phabricator.kde.org/R236:9b05a12a43dbe2b31a4655052f20de0832ac7a61> but never "upstreamed" to `KStyle`
  >
  > Sorry, did not know about this, and neither did the reviewer notice.
  >
  > Should I submit Diffs (or commit directly?) where the wrong icon is still in use, e.g. here <https://lxr.kde.org/source/extragear/base/qtcurve/qt5/style/qtcurve.cpp#1001>, here <https://lxr.kde.org/source/extragear/base/qtcurve/qt5/style/qtcurve.cpp#1055>, here <https://lxr.kde.org/source/frameworks/kdelibs4support/src/kdeui/k4style.cpp#0489> and/or here <https://lxr.kde.org/source/playground/artwork/oxygen-transparent/style/oxygenstyle.cpp#8204>?
  
  
  Yes please. Committing directly should be fine.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180808/0d98a009/attachment-0001.html>