D14674: handle non-ASCII encodings of file names in tar archives

Christoph Feck noreply at phabricator.kde.org
Tue Aug 7 17:09:13 BST 2018


cfeck added inline comments.

INLINE COMMENTS

> ktar.cpp:777
> +    // If more than 100 bytes, we need to use the LongLink trick
> +    if (encodedFileName.length() > 99) {
>          d->writeLonglink(buffer, encodedFileName, 'L', uname.constData(), gname.constData());

Does the spec say `> 99` or `> 100`? The comment and the code should match.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180807/26dfb0f9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list