D14579: api for multi level kcms

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kcmodule.cpp:59
>      QString m_ExportText;
> +    QList<QString> _levelTitles;
> +    uint _currentLevel = 0;

`QStringList`?

> kcmodule.h:273
> +     */
> +    uint depth() const;
> +

`uint` is quite unusual for our APIs, isn't it?

> kcmodule.h:286
> +     */
> +    int currentLevel() const;
> +

`setCurrentLevel` is `uint` but this returns `int`

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14579

To: mart, #plasma, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180807/cd7226cd/attachment.html>