D14666: Fixes memory leak in KUrlComboBox::setUrl

[David Faure]

dfaure resigned from this revision.
dfaure added a comment.


  The ownership was clear in the original code: itemList and defaultList own the items, the rest (like itemMapper) doesn't.
  So unique_ptrs in itemList and defaultList, and raw pointers elsewhere, would be perfectly fine and much clearer.
  Don't fall into the "no raw pointers" trap. The correct recommendation is "no raw pointers that own the object".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14666

To: hallas
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180807/094dd285/attachment.html>