D14666: Fixes memory leak in KUrlComboBox::setUrl

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in kurlcombobox.cpp:363
> Doesn't this have the same issue? delete missing

Sure has :) I was thinking if a nicer solution would be to use a smart pointer in the itemList instead? That way we wouldn't need to go hunting for this and risk introducing leaks again? Do we have any favorite smart pointer for this? Or would a std::unique_ptr be fine?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14666

To: hallas, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180807/327f7eef/attachment.html>